Add XDG Base Directory Specification support #7386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Mar 3, 2024
MaxDesiatov
requested changes
Mar 3, 2024
Contributor
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
We either need to use EnvironmentVariables.process() instead of ProcessInfo.processInfo.environment for improved Windows handling in the future, or exclude this logic on Windows altogether.
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Contributor
|
@swift-ci test |
MaxDesiatov
reviewed
Mar 3, 2024
Contributor
|
@swift-ci test |
Contributor
|
@swift-ci test windows |
|
Thank you!! |
|
Thank you for working on this! Will this be released in Swift 6.0, or maybe earlier? |
Contributor
|
5.10 has been released already. Swift 6.0 is branching off |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: As discussed in swiftlang#6204, users would like to have a clean home directory. And in the discussions following the merge of swiftlang#3430, it seems there is a willingness to adhere to the XDG spec, and support `~/.config/swiftpm`. ### Modifications: If the `XDG_CONFIG_HOME` environmental variable is defined, use `$XDG_CONFIG_HOME/swiftpm` as the root `dotSwiftPM` directory. ### Result: The symlinks that were previously stored in `~/.swiftpm` are now stored in `$XDG_CONFIG_HOME/swiftpm` when this variable is defined, therefore not cluttering the home directory of users. Closes swiftlang#6204 --------- Co-authored-by: Max Desiatov <m_desiatov@apple.com>
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: As discussed in swiftlang#6204, users would like to have a clean home directory. And in the discussions following the merge of swiftlang#3430, it seems there is a willingness to adhere to the XDG spec, and support `~/.config/swiftpm`. ### Modifications: If the `XDG_CONFIG_HOME` environmental variable is defined, use `$XDG_CONFIG_HOME/swiftpm` as the root `dotSwiftPM` directory. ### Result: The symlinks that were previously stored in `~/.swiftpm` are now stored in `$XDG_CONFIG_HOME/swiftpm` when this variable is defined, therefore not cluttering the home directory of users. Closes swiftlang#6204 --------- Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As discussed in #6204, users would like to have a clean home directory.
And in the discussions following the merge of #3430, it seems there is a willingness to adhere to the XDG spec, and support
~/.config/swiftpm.Modifications:
If the
XDG_CONFIG_HOMEenvironmental variable is defined, use$XDG_CONFIG_HOME/swiftpmas the rootdotSwiftPMdirectory.Result:
The symlinks that were previously stored in
~/.swiftpmare now stored in$XDG_CONFIG_HOME/swiftpmwhen this variable is defined, therefore not cluttering the home directory of users.Closes #6204