[PackageGraph] Allow package-level cyclic dependency only for >= 6.0 … #7579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
…manifests Follow-up to swiftlang#7530 Otherwise it might be suprising for package authors to discover that their packages cannot be used with older tools because they inadvertently introduced a cyclic dependency in a new version.
xedin
force-pushed
the
gate-cycle-dependencies-feature-on-6.0-tools
branch
from
8f966c4 to
3098b2d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
May 22, 2024
xedin
added a commit
that referenced
this pull request
Jun 1, 2024
… 6.0 … (#7617) …manifests - Explanation: Follow-up to #7530 Otherwise it might be surprising for package authors to discover that their packages cannot be used with older tools because they inadvertently introduced a cyclic dependency in a new version. - Scope: dependency resolution. - Main Branch PR: #7579 - Resolves: rdar://126217172 - Risk: Low - Reviewed By: @bnbarham - Testing: New tests added to the test suite. (cherry picked from commit 3098b2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…manifests
Motivation:
Follow-up to #7530
Otherwise it might be suprising for package authors to discover that their packages cannot be used with older tools because they inadvertently introduced a cyclic dependency in a new version.
Modifications:
ModulesGraph.loadhas been adjusted to runfindCyclesome of the root manifests support tools version that is older than 6.0. New diagnostic was added to help guide package authors to update their versions if they have cyclic package-level dependencies.Result:
Attempts to introduce cyclic package-level dependencies to manifests that support tools-versions less than 6.0 would result in a failure.