Skip to content

APIDiff.swift: Address warning by using task group instead of semaphore #7959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2024
Merged

APIDiff.swift: Address warning by using task group instead of semaphore #7959

merged 3 commits into from
Sep 15, 2024

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@MaxDesiatov
Copy link
Contributor

@swift-ci test

MaxDesiatov
MaxDesiatov reviewed Sep 11, 2024
View reviewed changes
@MaxDesiatov
Copy link
Contributor

@swift-ci test

@rauhul
Copy link
Member

rauhul commented Sep 11, 2024

Could we factor this into a more reusable component, like this?

Sequence+ParallelMap.swift.txt

@valeriyvan
Copy link
Contributor Author

Could we factor this into a more reusable component, like this?

Not in this PR. Open an issue if you think it does worth it.

MaxDesiatov
MaxDesiatov requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to add import _Concurrency to the file you've changed to fix CMake builds and unblock CI.

@valeriyvan
Copy link
Contributor Author

You'll have to add import _Concurrency to the file you've changed to fix CMake builds and unblock CI.

done

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) September 12, 2024 17:45
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov MaxDesiatov merged commit da65429 into swiftlang:main Sep 15, 2024
5 checks passed
@valeriyvan valeriyvan deleted the apidiff-taskgroup branch September 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis

@xedin xedin Awaiting requested review from xedin

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees

No one assigned

Labels

concurrency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valeriyvan @MaxDesiatov @rauhul