WIP: Implement SE-0455: SwiftPM @testable build setting #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
bnbarham,
MaxDesiatov,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
Untested draft. Will write up a proposal soon. |
|
Thanks! Yeah, really want to get some wide community feedback on this. Pretty much everyone fights with enable testing at some point or other. |
This introduces a new `enableTesting` API in SwiftSetting which allows targets to explicitly control whether testability is enabled, as some projects do not want to use the @testable feature. This can also improve debug build performance as significantly fewer symbols will be exported from the binary in the case where @testable is disabled. The default is equivalent to `enableTesting(true, .when(configuration: .debug))`, so there is no behavior change from today without explicitly adopting this new API. The --enable-testable-imports/--disable-testable-imports command line flags now acts as overrides -- if specified, they will override any build settings configured at the target level, and if unspecified, the target-level settings will be respected.
jakepetroules
force-pushed
the
enable-testing-build-setting
branch
from
b29b9e1 to
0d6fa53
Compare
jakepetroules
commented
Jan 30, 2025
| @@ -1016,6 +1016,12 @@ public final class PackageBuilder { | |||
| } | |||
| } | |||
|
|
|||
| for setting in manifestTarget.settings { | |||
| if case let .enableTestableImport(enable) = setting.kind, enable, setting.condition?.config == "release" { | |||
There was a problem hiding this comment.
I might need to check for config==nil as well
jakepetroules
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
enableTestingAPI in SwiftSetting which allows targets to explicitly control whether testability is enabled, as some projects do not want to use the@testablefeature. This can also improve debug build performance as significantly fewer symbols will be exported from the binary in the case where@testableis disabled.The default is equivalent to
enableTesting(true, .when(configuration: .debug)), so there is no behavior change from today without explicitly adopting this new API.The --enable-testable-imports/--disable-testable-imports command line flags now acts as overrides -- if specified, they will override any build settings configured at the target level, and if unspecified, the target-level settings will be respected.