Updates tests for execution on non Apple hosts. #8407
Conversation
kcieplak
commented
Mar 25, 2025
kcieplak
commented
- Update StringChecker to handle Windows line endings.
- Use .exe suffix for executables on Windows
- Use where.exe on Windows for tool location detection.
- Enable unconditionally skipped tests, marking with known issue where appropriate.
- Fix unconditionally skipped tests, skipping was added many years ago and never removed.
- Add matrix style testing for the build system (native/swiftbuild) on "swift init/build/test" tests.
kcieplak
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
kcieplak
force-pushed
the
topics/fix-up-swift-integration-tests
branch
from
0cb9f61 to
63ca4fb
Compare
|
@swift-ci test linux |
| @@ -22,13 +23,15 @@ private struct BasicTests { | |||
| @Test( | |||
| .skipSwiftCISelfHosted( | |||
| "These packages don't use the latest runtime library, which doesn't work with self-hosted builds." | |||
| ) | |||
| ), | |||
| .skipHostOS(.windows, "random.swift:34:8: error: unsupported platform") | |||
There was a problem hiding this comment.
Let's get a GitHub issue filed for that error
|
CI is failing on linux self hosted tests.
I can add a known issue but I think that other CI pipelines where a SDK is installed at /usr/ might not cause the error and will fail. Trying to find a solution. |
kcieplak
force-pushed
the
topics/fix-up-swift-integration-tests
branch
from
63ca4fb to
fe58ae5
Compare
|
@swift-ci test |
|
|
@swift-ci test windows |
|
@swift-ci test macOS |
kcieplak
force-pushed
the
topics/fix-up-swift-integration-tests
branch
from
fe58ae5 to
b4065c1
Compare
|
@swift-ci test |
|
@swift-ci please test windows |
| // #expect(stdout.contains("Hello, world!")) | ||
| try sh(swiftBuild, "--package-path", packagePath, "--build-system", buildSystemProvider.rawValue) | ||
|
|
||
| try withKnownIssue("Issue #8416 - error while loading shared libraries: libswiftCore.so: cannot open shared object file: No such file or directory") { |
There was a problem hiding this comment.
praise: Thanks for linking to a GitHub issue for this with the details of the problem. I've tagged it with the "swift build" label for integration tracking purposes.
| @@ -23,13 +24,15 @@ private struct BasicTests { | |||
| .skipSwiftCISelfHosted( | |||
| "These packages don't use the latest runtime library, which doesn't work with self-hosted builds." | |||
| ), | |||
| .requireUnrestrictedNetworkAccess("Test requires access to https://github.com") | |||
| .requireUnrestrictedNetworkAccess("Test requires access to https://github.com"), | |||
| .skipHostOS(.windows, "Issue #8409 - random.swift:34:8: error: unsupported platform") | |||
There was a problem hiding this comment.
suggestion (if-minor, if-updating): Can we use the .bug trait and include the URL to the GitHub issue?
FYI: There is no need to update the PR just to address this, but something to keep in mind for subsequent changes.
|
@swift-ci please test |
|
@swift-ci please test windows |
- Update StringChecker to handle Windows line endings. - Use .exe suffix for executables on Windows - Use where.exe on Windows for tool location detection. - Enable unconditionally skipped tests, marking with known issue where appropriate. - Fix unconditionally skipped tests, skipping was added many years ago and never removed. - Add matrix style testing for the build system (native/swiftbuild) on "swift init/build/test" tests.
* Add .bug() traits to tests allowing for tracking swift-build integration issues using the "SWBINTTODO" comment string. * bugs with id 0, and SWBINTTODO indicate there needs to be a GH raised. * bugs with a URL indicate there is a tracking issue.
kcieplak
force-pushed
the
topics/fix-up-swift-integration-tests
branch
from
df81e19 to
9b842b0
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci please test windows |
|
@swift-ci please test self hosted windows |
