Activate swift build support for command plugins #8845
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Filter dynamic targets when discovering configured targets Use the build plan and binary path for the native build system tool path calculation
|
@swift-ci please test |
Add runtime library environment to the command plugin invocation for the tools that it runs
|
@swift-ci please test |
Fix failing package command test
Skip testCommandPluginTargetBuilds on Linux due to bug building fixture in release mode Skip testCommandPluginSymbolGraphCallbacks until symbol graph callback is supported with swiftbuild
|
@swift-ci please test |
|
@swift-ci please test |
…scope Skip test on autolink extract errors on non-macOS platforms
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be consistent in the detection of the build system settings so that both the
build system and the build parameters are using the same setting. Use the
build system setting given after the command plugin name as the highest
precedence, followed by the one (if any) provided after the package subcommand.
When building a specific target with the swiftbuild build system, set the configured
target in the build request to be the one that isn't a dynamic target.
Tag the
TraitTest.packagePluginGetSymbolGraph_enablesAllTraitswith a knownissue when using the swiftbuild build system since the symbol graph extraction
is not yet working there.
Add the toolchain's runtime environment to the environment used when running
command plugins so that the tools have the necessary runtime dependencies when
the plugin decides to run them on platforms like Linux.