Tests: Migrate 2 suites to Swift Testing #9017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
force-pushed
the
tt/main/gh8997_rdar157669245_migrate_SwiftDDKCommandTests_to_ST_and_augment
branch
from
56d2213 to
2e0a0ef
Compare
bkhouri
force-pushed
the
tt/main/gh8997_rdar157669245_migrate_SwiftDDKCommandTests_to_ST_and_augment
branch
2 times, most recently
from
5954b71 to
47f63a3
Compare
|
@swift-ci test |
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
bkhouri
changed the title
Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
force-pushed
the
tt/main/gh8997_rdar157669245_migrate_SwiftDDKCommandTests_to_ST_and_augment
branch
from
47f63a3 to
ee16803
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bripeticca
approved these changes
Sep 2, 2025
| return false | ||
| } | ||
| } | ||
| return true |
There was a problem hiding this comment.
suggestion (non-blocking): for fun, you could also make this helper a one-line implementation! :D
return subset.allSatisfy({ array.contains($0) })
There was a problem hiding this comment.
Thanks for this. I'll address this in a follow-up change.
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Oct 2, 2025
Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate a few suites to Swift Teting, namely,
Depends on: #9012
Relates to: #8997
issue: rdar://157669245