Generate entrypoints for test bundles on macOS #9018
Conversation
|
@swift-ci test |
| } | ||
|
|
||
| // When building with the CLI for macOS, test bundles should generate entrypoints for compatibility with swiftpm-testing-helper. | ||
| if buildParameters.triple.isMacOSX { |
There was a problem hiding this comment.
macOS, or all Darwin?
There was a problem hiding this comment.
Well we don't support command-line execution of tests on other Apple platforms anyway, so...
There was a problem hiding this comment.
Execution doesn't matter, this is about the build. The build system does not assume that the machine/tool building the tests is the one running them.
There was a problem hiding this comment.
Okay: we support neither building nor executing tests on iOS using SwiftPM.
owenv
force-pushed
the
owenv/macos-entry
branch
from
627f0ba to
b19a7f1
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
owenv
force-pushed
the
owenv/macos-entry
branch
from
b19a7f1 to
86ad587
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test self hosted |
owenv
force-pushed
the
owenv/macos-entry
branch
from
86ad587 to
dc198e1
Compare
|
@swift-ci test self hosted |
owenv
force-pushed
the
owenv/macos-entry
branch
from
dc198e1 to
2a9d838
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
One remaining text failure should be fixed by #9115 |
owenv
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
plemarquand and
shawnhyam
as code owners
|
@swift-ci test self hosted |
| if let toolchainID = try await session.lookupToolchain(at: buildParameters.toolchain.toolchainDir.pathString) { | ||
| settings["TOOLCHAINS"] = "\(toolchainID.rawValue) $(inherited)" | ||
| } else { | ||
| // FIXME: This list of overrides is incomplete. |
There was a problem hiding this comment.
issue: Do we have a GitHub issue tracking this FIXME? If so, can we add it as a code comment?
| } | ||
| } when: { | ||
| buildSystem == .swiftbuild | ||
| buildSystem == .swiftbuild && ProcessInfo.hostOperatingSystem != .macOS |
There was a problem hiding this comment.
issue (possibly blocking): Do we know why this test failed on Linux and Windows? Could we add an issue trait to the test to track it?
There was a problem hiding this comment.
This patch fixed it on macOS, linux/windows now hit a different underlying issue which needs further investigation
| } | ||
|
|
||
| @Test( | ||
| .issue("https://github.com/swiftlang/swift-package-manager/issues/8955", relationship: .defect), |
There was a problem hiding this comment.
suggestion: This issue is merged. Can we remove the withKnownIssue block to confirm whether the test now always passes?
There was a problem hiding this comment.
This also hits a different underlying issue now that the first one is fixed which needs further investigation
5 participants
Closes #8973
Ensure test bundles get a main symbol on macOS so swiftpm-testing-helper can kick off tests. We may want to rename this entrypoint to solve some issues with testable executables though.