Skip to content

Add SwiftBuild coverage support #9162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

Add SwiftBuild coverage support #9162

merged 1 commit into from
Oct 4, 2025

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Sep 20, 2025 •
edited
Loading

Ensure the SwiftBuild build system has feature parity with the Native build system as it relates to coverage.

Fixes: #9077
Fixes: #9197
Depends on: swiftlang/swift-build#844
Issue: rdar://159461439

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 20, 2025

@swift-ci test

owenv
owenv reviewed Sep 20, 2025
View reviewed changes
Tests/CommandsTests/BuildCommandTests.swift
)
func buildSystemOverrides(
buildSystem: BuildSystemProvider.Kind,
data: BuildData,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should default to running all these tests in debug and release - the difference isn't relevant to many of them and it extends the runtime quite a bit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8984 could say otherwise :)

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from c3cfde3 to 281fb9c Compare September 22, 2025 16:03
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 22, 2025

@swift-ci test self hosted

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 281fb9c to 5a190d5 Compare September 23, 2025 15:35
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 23, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 5a190d5 to 6ef6eb4 Compare September 23, 2025 16:05
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 23, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 6ef6eb4 to ff983fb Compare September 25, 2025 00:53
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025 •
edited
Loading

The macOS and Linux smoke builds failed for an infrastructure issue while cloning the dependant projects. Let's re-trigger them.

@swift-ci test linux

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025

@swift-ci test macOS

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from ff983fb to 62a1f39 Compare September 25, 2025 13:36
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 25, 2025

@swift-ci test windows

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 62a1f39 to 2d7b929 Compare September 26, 2025 14:26
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 26, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 2d7b929 to a15f3a9 Compare September 26, 2025 19:31
@bkhouri
Copy link
Contributor Author

bkhouri commented Sep 26, 2025

@swift-ci test

owenv
owenv reviewed Oct 2, 2025
View reviewed changes
owenv
owenv reviewed Oct 2, 2025
View reviewed changes
owenv
owenv reviewed Oct 2, 2025
View reviewed changes
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 2, 2025

The Windows self hosted pipeline failed with the following

[2025-10-02T00:37:39.789Z] × Test entryPointOverride(_:) recorded an issue with 1 argument buildSystem → .native at TestDiscoveryTests.swift:106:17: Expectation failed: (stdout → "").contains(random → "9A4AC6F2-AB4D-4D13-8DCA-3F65DEB5D768")

Let's re-trigger

@swift-ci test self hosted windows

owenv
owenv reviewed Oct 2, 2025
View reviewed changes
@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 2059e18 to f051004 Compare October 2, 2025 17:59
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 2, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 2, 2025

@swift-ci test windows

@bkhouri bkhouri mentioned this pull request Oct 2, 2025
Draft
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

The self hosted windows build timeout while executing the Swift Testing tests. let's re-trigger the build

@swift-ci test self hosted windows

@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from f051004 to 36b6a41 Compare October 3, 2025 17:29
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

swiftlang/swift-build#844

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

swiftlang/swift-build#844

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test linux

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test

@bkhouri bkhouri requested a review from owenv October 3, 2025 19:56
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test linux

@bkhouri
Add SwiftBuild coverage support
d9ff7df 
Ensure the SwiftBuild build systam has feature parity with the Native
build system as it relates to coverage.

Fixes: swiftlang#9077
Fixes: swiftlang#9197
Issue: rdar://159461439
@bkhouri bkhouri force-pushed the t/main/gh9077_rdar159461439_SwiftBuildWithCoverage branch from 36b6a41 to d9ff7df Compare October 3, 2025 21:51
@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 3, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 4, 2025

@swift-ci test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented Oct 4, 2025

@swift-ci test Linux

@bkhouri bkhouri merged commit acd7b00 into swiftlang:main Oct 4, 2025
6 checks passed
Azoy added a commit to Azoy/swift-package-manager that referenced this pull request Oct 8, 2025
@Azoy
Revert "Add SwiftBuild coverage support (swiftlang#9162)"
1de4680 
This reverts commit acd7b00.
@Azoy Azoy mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@bripeticca bripeticca bripeticca approved these changes

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

+1 more reviewer

@jabari-max jabari-max jabari-max approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@bkhouri @owenv @bripeticca @jabari-max