Clean up test traits #9214
Merged
Clean up test traits #9214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh8416_remote_issue_from-tests
branch
from
d4b4706 to
5118105
Compare
Contributor
Author
|
@swift-ci test |
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
Contributor
Author
|
@swift-ci test windows |
The change in swiftlang#8884 fixed the root cause, but did not update all the tests accordingly as some tests unnecessarily contained a `withKnownIssue` block. Remove the remaining `withKnownIssues` and the defect trait from the test. Closes: swiftlang#8416
bkhouri
force-pushed
the
t/main/gh8416_remote_issue_from-tests
branch
from
5118105 to
bea56de
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
A test in the windows self hosted pipeline failed Re-triggering the build @swift-ci test self hosted windows |
owenv
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #8884 fixed the root cause, but did not update all the tests accordingly as some tests unnecessarily contained a
withKnownIssueblock.Remove the remaining
withKnownIssuesand the defect trait from the test.Closes: #8416