Disable ONLY_ACTIVE_ARCH when --arch is used to request more than one explicitly #9303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Oct 29, 2025
| targetArchitecture: buildParameters.triple.archName, | ||
| supportedArchitectures: [], | ||
| disableOnlyActiveArch: false | ||
| disableOnlyActiveArch: (buildParameters.architectures?.count ?? 1) > 1 |
There was a problem hiding this comment.
Should we just always disable this?
There was a problem hiding this comment.
I think if you do a debug build and don't explicitly specify any target/arch we probably shouldn't build universal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that even in a debug build, we build a universal binary on macOS if it's requested.
Closes #8982 by resolving the remaining issue building swiftly with the Swift Build backend