-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate SDKSettings.json file for Swift SDKs for Swift 5.9-6.0 #185
Open
xtremekforever
wants to merge
5
commits into
swiftlang:main
Choose a base branch
from
xtremekforever:sdk-settings-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d 6.0 - Swift 6.1 and later supress this error automatically.
MaxDesiatov
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mind adding a test for this?
- Cover a few different arch names and ensure the correct file output is included.
kateinoigakukun
approved these changes
Feb 15, 2025
MaxDesiatov
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall makes sense, just a function naming nit to pick.
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that the warnings about the
SDKSettings.json
file were fixed in Swift 6.1 and later and that issue #110 was closed. However, we are still generating Swift SDKs for 5.9, 5.10, and 6.0 which all give the warnings.So, my suggestion is to generate this
SDKSettings.json
file for versions older than 6.1, similar to how the the Linux Static Swift SDKs do it. Here is the file that comes in theswift-6.0.3-RELEASE_static-linux-0.0.1
Swift SDK for example:Taking inspiration from this, I am generating a similar file for Swift SDKs created by the generator:
The ordering is not the same due to how
JSONEncoder()
sorts things, and the formatting is a little different too due to.prettyPrinted
, but it works just the same. And, the "warning: Could not read SDKSettings.json for SDK at: " warning is successfully suppressed.This really is a minor change that is more "quality-of-life" then adding any functionality. But, not having those warnings printed when using the generated Swift SDKs are used is a nice to have.
@MaxDesiatov @euanh @kateinoigakukun