Don’t set SWIFT_BUILD_SCRIPT_ENVIRONMENT when building swift-format
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SWIFT_BUILD_SCRIPT_ENVIRONMENT` should only be set when building swift-syntax. All other projects should be building swift-syntax without any swift-syntax-specific environment variables set. Also remove `SWIFT_SYNTAX_PARSER_LIB_SEARCH_PATH`, which isn’t needed anymore since we re-wrote the parser in Swift and we no longer have the C++ parser library.
Member
Author
|
@swift-ci Please test |
bnbarham
reviewed
Sep 15, 2023
Comment on lines
-195
to
-197
| # Tell SwiftSyntax that we are building in a build-script environment so that | ||
| # it does not need to rebuilt if it has already been built before. | ||
| env['SWIFT_BUILD_SCRIPT_ENVIRONMENT'] = '1' |
Contributor
There was a problem hiding this comment.
Are you removing this from all the build script helpers? Will it just be set in solely swift-syntax/SwiftSyntaxDevUtils now?
Member
Author
There was a problem hiding this comment.
Yes, and then I’ll probably rename it to something more descriptive. This used to be used to set --check-exclusivity=unchecked, which decreased compile time of swift-syntax by 2 minute at some point but that’s no longer the case.
bnbarham
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT_BUILD_SCRIPT_ENVIRONMENTshould only be set when building swift-syntax. All other projects should be building swift-syntax without any swift-syntax-specific environment variables set.Also remove
SWIFT_SYNTAX_PARSER_LIB_SEARCH_PATH, which isn’t needed anymore since we re-wrote the parser in Swift and we no longer have the C++ parser library.