Improve diagnostics message for init declaration #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Mar 9, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thank you @StevenWong12, this PR is going and the right direction and the improvements in the tests are looking good. I’ve put a few comments inline.
StevenWong12
force-pushed
the
produce-message-for-named-init
branch
from
eb4ee76 to
0d73e89
Compare
ahoppen
approved these changes
Mar 10, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Nice. Thank you. This looks good 👍
Member
|
@swift-ci Please test |
Member
|
@StevenWong12 I approved but when I hit approve I forgot that I still had an open comment. If you could address #1397 (comment), I’ll merge the PR. |
StevenWong12
force-pushed
the
produce-message-for-named-init
branch
from
c7a565d to
2d02851
Compare
Contributor
Author
|
Hey @ahoppen, I think the .raw is redundant. Already removed it😀. |
Member
|
Thank you. |
Member
|
@swift-ci Please test |
1 similar comment
Member
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed part of TODOs in #1373
Also fixed a TODO in
InitDeinitTests.swift