[Plugin] Add 'loadPluginLibrary' message #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
plugin-dylibmacro
branch
2 times, most recently
from
19b43d5 to
be668a7
Compare
|
@swift-ci Please test |
rintaro
commented
Mar 15, 2023
Sources/SwiftCompilerPluginMessageHandling/PluginMessages.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCompilerPluginMessageHandling/CompilerPluginMessageHandler.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCompilerPluginMessageHandling/CompilerPluginMessageHandler.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCompilerPluginMessageHandling/CompilerPluginMessageHandler.swift
Outdated
Show resolved
Hide resolved
rintaro
force-pushed
the
plugin-dylibmacro
branch
from
be668a7 to
0e6ec19
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Mar 16, 2023
bnbarham
approved these changes
Mar 17, 2023
Comment on lines
16
to
18
| public enum PluginFeature: String { | ||
| case loadPluginLibrary | ||
| } |
There was a problem hiding this comment.
I'd prefer PluginFeature to have specific values set so that a global rename doesn't accidentally change the protocol.
|
@swift-ci please test Windows platform |
This message is to load a dynamic link library from the specified path. Later on, the loaded macro should be usable just like the normal macro expansion. Also, add 'features' to the capability message. Plugin implementations can declare the optional features they implement. 'CompilerPlugin' doesn't implement any optional features at this point.
rintaro
force-pushed
the
plugin-dylibmacro
branch
from
0e6ec19 to
6b677f7
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for swiftlang/swift#64376 but can be applied independently.
This message is to load a dynamic link library from the specified path. Later on, the loaded macro should be usable just like the normal macro expansion.
Also, add
featuresto the capability message. Plugin implementations can declare the optional features they implement.CompilerPlugindoesn't implement any optional features at this point.Also, add
SwiftCompilerPluginMessageHandlingto the CMake build.