[5.9] Cherry-Pick multiple PRs to release/5.9 #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides the standard `assert` function from the stdlib with a version also checks the condition in CI if a conditional compilation flag is passed.
The check here should be inverted.
Remove an unused method, and remove some redundant logic.
By default Xcode saves an xctestplan directly in the `.swiftpm` directory if you change any of its default values (e.g when enabling code coverage). As such, ignore the entire `.swiftpm` directly, not just `.swiftpm/xcode`. Also ignore it for any child directories, avoiding the need to have separate `.gitignore`s for child SwiftPM projects.
…s-version-comparison fixed testAvailabilityQuery34 and testAvailabilityQueryUnavailability28
I disabled all of those rules to make the introduction of swift-format easiser. Now I went through them again and these rules are satisfied. All the other rules that are disabled have good reasons for being diabled, so I want to keep them disabled. rdar://103919185
Enable assertions in CI even if we are building in release builds
Remove remaining references to gyb
…rmat-rules Enable two swift-format rules that are now satisfied
Member
Author
|
@swift-ci Please test |
ahoppen
changed the title
bnbarham
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs to
release/5.9:.gitignoreto always ignore.swiftpm#1431All of them satisfy either of these criteria and are thus valuable to cherry-pick IMO:
maintorelease/5.9