Document that Trivia cannot represent invalid UTF-8
#1490
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
rintaro
reviewed
Apr 4, 2023
| /// Note: `Trivia` is not able to represent invalid UTF-8 sequences. To get | ||
| /// the leading trivia text including all invalid UTF-8 sequences, use | ||
| /// ``` | ||
| /// node.syntaxTextBytes[(node.byteSize - node.trailingTriviaLength.utf8Length)...] |
Member
There was a problem hiding this comment.
Maybe
node.syntaxTextBytes.suffix(node.trailingTriviaLength.utf8Length)looks easier. But it doesn't really matter
Member
Author
There was a problem hiding this comment.
Actually, there is no suffix on Array. But I took the suggestion for prefix.
rintaro
approved these changes
Apr 4, 2023
ahoppen
force-pushed
the
ahoppen/trivia-invalid-utf8
branch
from
8a82241 to
fe6ab43
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test macOS |
Member
Author
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…-utf8 Document that `Trivia` cannot represent invalid UTF-8
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…-utf8 Document that `Trivia` cannot represent invalid UTF-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.