[5.9] Add a function to merge trivia from a node into an existing trivia #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual `Trivia` definition doesn't need to be generated at all, only the static funcs and vars. Move it into SwiftSyntax proper. (cherry picked from commit cb0f24e)
Generally when a node is removed, we need to add its trivia to an existing node. Add a small helper function to aid in this case. (cherry picked from commit ca6d6b5)
Contributor
Author
|
@swift-ci please test |
DougGregor
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triviaso only the parts that have to be generated are.Trivia.mergingmethods