Fix debugInitCall #1543
Merged
Fix debugInitCall #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/fix-debuginitcall
branch
from
09f9c9b to
f1f846b
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/fix-debuginitcall
branch
from
f1f846b to
c017cfd
Compare
Member
Author
|
@swift-ci Please test |
Contributor
|
@swift-ci please test windows |
bnbarham
approved these changes
Apr 29, 2023
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
I'd personally prefer not having the runtime hackery by making the assumption that SyntaxChildChoices is within a type and then:
- Not supporting printing
SyntaxChildChoicesdirectly (can override to print something to that effect) - Pass down the parent type name when making the recursive call
But it's just a debug call and only in _SwiftSyntaxTestSupport so I don't feel super strongly about that. Any thoughts @rintaro?
I broke `debugInitCall` when I removed the custom mirrors for syntax nodes. Fix it again, also fixing some more issues along the way that previously caused us to generate Swift code that didn’t compile.
ahoppen
force-pushed
the
ahoppen/fix-debuginitcall
branch
from
c017cfd to
6017000
Compare
Member
Author
|
I found a fairly elegant solution without calling into the runtime. |
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Contributor
Ah, I forgot we had |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke
debugInitCallwhen I removed the custom mirrors for syntax nodes. Fix it again, also fixing some more issues along the way that previously caused us to generate Swift code that didn’t compile.