[5.9] Make column and line non-optional
#1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/cherry-pick-remove-computed-location
branch
from
fe9869e to
d8bf0d0
Compare
This was referenced May 18, 2023
Contributor
Author
bnbarham
approved these changes
May 19, 2023
Contributor
Author
3 similar comments
Contributor
Author
Contributor
Author
Contributor
Author
DougGregor
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceLocation.line,SourceLocation.columnandSourceLocation.filewere optional because at some point we intended for them to be lazily computed (or something of the sort). But that never really turned out to be useful, and we were left with optional variables that were nevernilif created from SwiftSyntax itself. Make them non-optionalSourceLocationAPISourceLocationshould not have an optionallineandcolumn#1525