Update CodeGeneration #1567
Merged
Update CodeGeneration #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
kimdv
approved these changes
Apr 21, 2023
Comment on lines
+519
to
+520
| presence: presence | ||
Contributor
There was a problem hiding this comment.
There are multiple places with with white space.
Also think that Doug mentioned it.
Contributor
There was a problem hiding this comment.
@ahoppen this one seems pretty weird to me:
- I thought we were stripping trailing whitespace
- We shouldn't be adding a newline here. Seems like that was broken before and after though
Member
Author
There was a problem hiding this comment.
This is the formatter subclass of BasicFormat that lives in CodeGeneration messing things up.
I’ll fix it in a follow-up PR
Contributor
|
@ahoppen how much white space did we remove? 😅😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.