[5.9] Remove deprecated methods from SwiftSyntaxMacros #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
ahoppen
changed the title
Member
Author
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Apr 25, 2023
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/5.9/no-deprecations
branch
from
f3e7d20 to
af4d597
Compare
ahoppen
force-pushed
the
ahoppen/5.9/no-deprecations
branch
from
af4d597 to
30409dd
Compare
Member
Author
|
@swift-ci Please test |
1 similar comment
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createUniqueNameandlocation(…) -> SourceLocation?were both introduced with SwiftSyntax 509 and are immediately marked as deprecated. ForcreateUniqueName, that’s not a gigantic issue, just a weirdness but forlocation(…) -> SourceLocation?shadows the non-deprecated@_disfavoredOverload location(…) -> AbstractSourceLocation?, which means that to use the non-deprecated function, you need to add explicit type annotations. Remove the deprecated methods since nobody should be using them up until now anyway.Cherry-pick #1555 to release/5.9.