Skip to content

Conversation

@kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 25, 2023

  • Explanation: When there was a Python style inheritance the parser did show an "unexpected code" error. This will show a correct error and fix-it
  • Scope: Swift parser and diagnostics
  • Risk: Low
  • Testing: Added test cases that converts Python style inheritance to Swift inheritance
  • Issue: N/A
  • Reviewer: @ahoppen on Add diagnostic for wrong inheritance #1450

@kimdv kimdv requested a review from ahoppen as a code owner April 25, 2023 18:39
…-wrong-inheritance

Add diagnostic for wrong inheritance
@kimdv kimdv force-pushed the kimdv/cherry-pick-add-diagnostic-for-wrong-inheritance branch from b4d3817 to 731e46a Compare May 22, 2023 07:51
@ahoppen
Copy link
Member

ahoppen commented May 22, 2023

Looking at this PR again, I’d prefer not to cherry-pick it to 5.9. The change seems potentially risky (because isAtPythonStyleInheritanceClause is not super trivial) and the use case is very marginal.

@ahoppen ahoppen closed this May 22, 2023
@kimdv kimdv deleted the kimdv/cherry-pick-add-diagnostic-for-wrong-inheritance branch May 23, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants