[5.9] Emit error for unterminated block comment #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
May 2, 2023
ahoppen
commented
- Explanation: The new parser was accepting unterminated block comments, which was no good. Add a lever diagnostic for them
- Scope: Lexing of block comments
- Risk: We could be rejecting source code in the new parser now, but I think that’s unlikely
- Testing: Added regression test
- Issue: rdar://107424615
- Reviewer: @bnbarham and @hamishknight on Emit error for unterminated block comment #1619
Fixes swiftlang#1468 Resolves rdar://107424615
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
DougGregor
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.