[5.9] Update Package.swift and .spi.yml to make them match
#1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package.swift and `.spi.yml` have drifted apart and didn’t actually match anymore. The targets declared in `.spi.yml` should match the libraries declared in the package manifest. To fix this, update `.spi.yml` and also declare `SwiftBasicFormat` as a library in `Package.swift`. BasicFormat is being used in sufficently many places by now that we can’t really consider it an implementation detail of SwiftSyntax anymore. rdar://108902357
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Contributor
|
@swift-ci Please test Windows |
kimdv
approved these changes
May 5, 2023
DougGregor
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.spi.ymlhave drifted apart and didn’t actually match anymore. The targets declared in.spi.ymlshould match the libraries declared in the package manifest. To fix this, update.spi.ymland also declareSwiftBasicFormatas a library inPackage.swift. BasicFormat is being used in sufficently many places by now that we can’t really consider it an implementation detail of SwiftSyntax anymore. This causes us to not render documentation for some targets on swiftpackageindex.comSwiftBasicFormatSwiftBasicFormat, which should be safe.spi.ymlto make them match #1636