-
Notifications
You must be signed in to change notification settings - Fork 472
[5.9] Fix newline parsing at trailing trivia #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.9] Fix newline parsing at trailing trivia #1671
Conversation
… the isAtStartOfLine flag
| import XCTest | ||
| @_spi(RawSyntax) import SwiftSyntax | ||
| @_spi(Testing)@_spi(RawSyntax) import SwiftParser | ||
| @_spi(Testing) @_spi(RawSyntax) import SwiftParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran format.py before opening the PR, and it made this change 🤔
Should I include this in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that’s because the 5.9 swift-format doesn’t add a space here. It shouldn’t be included in the PR or CI will complain that the release/5.9 branch is not formatted correctly according to the release/5.9 branch of swift-format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, I understand. I removed the formatting commit. Thank you for explaining it 🙂
|
|
||
| @_spi(RawSyntax) import SwiftSyntax | ||
| @_spi(Testing)@_spi(RawSyntax) import SwiftParser | ||
| @_spi(Testing) @_spi(RawSyntax) import SwiftParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also the same.
4b82be7 to
32f9b25
Compare
|
@swift-ci Please test |
Uh oh!
There was an error while loading. Please reload this page.