Use marker to mark SourceEdits
#1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
May 22, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
With your comment on the other PR (#1662 (comment)), I think being explicit about the edits makes a lot of sense. Thanks for doing this. I have a few comments inline but the design looks good overall.
StevenWong12
force-pushed
the
use_marker_to_mark_source_edits
branch
from
dcc35e7 to
8778124
Compare
StevenWong12
force-pushed
the
use_marker_to_mark_source_edits
branch
from
8778124 to
5fd5219
Compare
ahoppen
reviewed
May 25, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
I’ve got a few code style comments, otherwise this looks very good to me.
This change is used to help us mark the changes in source file, which makes incremental parsing test easier.
StevenWong12
force-pushed
the
use_marker_to_mark_source_edits
branch
from
43e0c33 to
b605766
Compare
Member
|
@swift-ci Please test |
Member
|
CI failed for an unrelated reason. I’ll re-trigger it tomorrow |
Member
|
@swift-ci Please test macOS |
Member
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is used to help us mark the changes in source file, which makes incremental parsing test easier.
See comments in #1662 (comment)