[5.9] fix wrong diagnostic for wrong pattern #1687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kimdv
commented
May 22, 2023
kimdv
commented
- Explanation: If there was two identifiers with a space between, followed by a colon and a type, the parser didn't suggest a fix-it to merge them, neither did it show the correct diagnostic.
- Scope: Swift parser and diagnostics
- Risk: Low
- Testing: Added correct test cases
- Issue: N/A
- Reviewer: @ahoppen on Fix wrong diagnostic parse typed pattern #1580
…ic-for-wrong-pattern
ahoppen
approved these changes
May 22, 2023
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Safe because this only touches an error recovery branch.
bnbarham
approved these changes
May 22, 2023
Member
|
@swift-ci Please test |
kimdv
deleted the
kimdv/cherry-pick-fix-wrong-diagnostic-for-wrong-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.