Fix it to emit a single diagnostic when both open and close quote are missing

[TTOzzi]

Resolve #1691

When a string segment is located between missing quotes on both sides, looking ahead is interrupted, and each quote is diagnosed separately.
I have modified the logic to continue looking ahead even if a standalone string segment is encountered during the search.
Furthermore, I added a condition to the parentContextClause in order to modify the diagnostic, but I am uncertain if it is the appropriate approach.
If there is a better solution available, please let me know. Thank you.

[ahoppen]

The way I would approach this is to add

public override func visit(_ node: StringLiteralExprSyntax) -> SyntaxVisitorContinueKind {

to ParseDiagnosticsGenerator. If both node.openQuote and node.closeQuote are missing, you can generate a custom error message.

[TTOzzi]

The way I would approach this is to add

public override func visit(_ node: StringLiteralExprSyntax) -> SyntaxVisitorContinueKind {

to ParseDiagnosticsGenerator. If both node.openQuote and node.closeQuote are missing, you can generate a custom error message.

Ah, I see! You're referring to calling addDiagnostic there.
I will make changes. Thank you again for your kind feedback every time.

[ahoppen]

Thank you. Looks very good. I only have a few minor comments to make it slightly more general

[ahoppen]

I suspect that this will change to insert '"' and '"' after #1651 is merged.

[TTOzzi]

Thank you for letting me know! Once that PR is merged, I will rebase to apply the changes 🙂

[ahoppen]

Thank you. This looks great now. Can you rebase it now that #1651 is merged? Afterwards, I’ll trigger CI.

[TTOzzi]

Thank you. This looks great now. Can you rebase it now that #1651 is merged? Afterwards, I’ll trigger CI.

I'm done! Thank you @ahoppen 🙌

[kimdv]

@swift-ci please test

[kimdv]

@swift-ci please test windows