Make DeclarationModifier and TypeAttribute normal TokenSpecSet instead of generating them
#1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
kimdv
approved these changes
May 30, 2023
Contributor
kimdv
left a comment
kimdv
left a comment
There was a problem hiding this comment.
Did you run the code generation? 😅
I see two templates removed from the list
ahoppen
force-pushed
the
ahoppen/normal-spec-sets
branch
from
bed03ed to
9273816
Compare
Member
Author
|
Oh, yeah. Apparently I missed the deletion of the generated files at some point |
Contributor
|
@swift-ci please test |
Member
Author
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/normal-spec-sets
branch
from
9273816 to
4233ff6
Compare
Member
Author
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 2, 2023
.github/ISSUE_TEMPLATE/config.yml
Outdated
| about: Ask and answer questions about SwiftSyntax | ||
| - name: SwiftSyntax Documentation | ||
| url: https://github.com/apple/swift-syntax/tree/main/Documentation | ||
| url: https://swiftpackageindex.com/apple/swift-syntax/documentation/swiftsyntax |
Contributor
There was a problem hiding this comment.
Didn't you already change this in another PR?
ahoppen
force-pushed
the
ahoppen/normal-spec-sets
branch
from
4233ff6 to
19c9116
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
…instead of generating them There’s no reason to generate these `TokenSpecSet` anymore.
ahoppen
force-pushed
the
ahoppen/normal-spec-sets
branch
from
19c9116 to
f2afad8
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s no reason to generate these
TokenSpecSetanymore.