Add performance tests for SyntaxVisitor to the test suite #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
approved these changes
Nov 8, 2019
Member
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Member
Author
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Add spaces after labels for overlooked stmt types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three XCTest performance tests that test performance of the
SyntaxRewriter,SyntaxVisitorandSyntaxAnyVisitor.Since the tests are run using XCTest, I found that they are sometimes fairly unstable. However, they should serve as a good common ground to check if a change has major performance impacts.
For more accurate performance measurement, I would still recommend writing a standalone command line utility that links against SwiftSyntax and does its own measurements.