Improve diagnostics for invalid version tuples

[TTOzzi]

Resolve #1613

During the process of rebasing the changes from the main branch, an issue arose, leading to the closure and reopening of the previous PR(#1717).
I sincerely apologize for the inconvenience caused.

Based on the feedback provided in the comment here(#1717 (comment)), I have made the necessary revisions and added several relevant test cases.

Accidentally clicked approve. I’ve had two more minor requests

[ahoppen]

One minor comment, otherwise LGTM.

[ahoppen]

You could just make unexpectedTokens a [RawTokenSyntax], which simplifies the code a little

Suggested change

	var unexpectedTokens: [RawSyntax] = []
	var keepGoing: RawTokenSyntax? = nil
	var loopProgress = LoopProgressCondition()
	repeat {
	if let keepGoing {
	unexpectedTokens.append(RawSyntax(keepGoing))
	}
	if let unexpectedVersion = self.consume(if: .integerLiteral, .floatingLiteral, .identifier) {
	unexpectedTokens.append(RawSyntax(unexpectedVersion))
	}
	keepGoing = self.consume(if: .period)
	} while keepGoing != nil && loopProgress.evaluate(currentToken)
	var unexpectedTokens: [RawTokenSyntax] = []
	var keepGoing: RawTokenSyntax? = nil
	var loopProgress = LoopProgressCondition()
	repeat {
	if let keepGoing {
	unexpectedTokens.append(keepGoing)
	}
	if let unexpectedVersion = self.consume(if: .integerLiteral, .floatingLiteral, .identifier) {
	unexpectedTokens.append(unexpectedVersion)
	}
	keepGoing = self.consume(if: .period)
	} while keepGoing != nil && loopProgress.evaluate(currentToken)

[TTOzzi]

I have committed your suggestion, thank you!

[ahoppen]

Great, thanks. Let’s see what CI says.

[ahoppen]

@swift-ci Please test

[TTOzzi]

Hello @ahoppen 👋 It seems like the CI is completed. When can it be merged?

[ahoppen]

Thanks for the ping. I forgot about this PR. I’m sorry.