[Syntax] Provide a Syntax constructor that can accept an optional parameter
#181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
…arameter Also add test to ensure the casting to `SyntaxEnum` via optional chaining works as expected.
akyrtzi
force-pushed
the
cast-client-types
branch
from
ebb1a0c to
c22a9a8
Compare
akyrtzi
changed the title
Syntax constructor that can accept an optional parameter
Contributor
Author
|
The generic cast function has a serious flaw in that it is preferred over a specific cast function that returns non-optional, when optional chaining. I've reverted to original casts and kept only the |
Contributor
Author
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Rearrange breaks so class decls won't overflow line length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add test to ensure the casting to
SyntaxEnumvia optional chaining works as expected.