Add API to infer the indentation of a syntax tree #2514
Conversation
Part of rdar://123600798
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
1 similar comment
|
@swift-ci Please test macOS |
| // Pick biggest indentation that encompasses at least 90% of the source lines. | ||
| let threshold = Int(Double(visitor.linesProcessed) * 0.9) | ||
|
|
||
| for spaceIndentation in [8, 4, 2] { |
There was a problem hiding this comment.
Poor 3 space users 😅. Is 8 actually a thing that people use?
I think one issue we're likely to run into here is that for highly nested snippets, this is often going to return 8 even if it's eg. 2 space. Is the idea that this would only be run on entire files/functions/something else?
There was a problem hiding this comment.
That shouldn’t be an issue. If we have 4 lines indented with 8 spaces and 1 line indented with 10 spaces, we’ll infer the indentation to 2 spaces because only 80% of the lines have an indentation that’s a multiple of 8 but all lines have an indentation that’s a multiple of 2.
And I think I’ve seen codebases with 8 spaces of indentation. Can’t remember where and when, though.
Part of rdar://123600798