Significantly improve performance of SyntaxVisitor #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
Member
Author
|
Added a commit that stores which slots in |
There are two core ideas here: - Before this change, we were allocating `Syntax.Info` for every visited node. We need a heap-allocated object here because `Syntax` can access its parent. In most cases, however, the syntax node was not stored by the visitor and we would just destroy the `Syntax.Info` after finishing the `visit` call. Instead, check if `Syntax.Info` is uniquely referenced, which means that the the node was not stored. In that case, don’t deallocate the memory but place it into a reuse pool. I have seen reductions in `malloc` calls from ~50,000 to ~100 (500x) in `testEmptyVisitorPerformance`. - Now retain and release calls made up a significant portion of the visitor’s performance. Add some annotations to eliminate reference counting. I added comments for the remaining retain calls. I measured that this improves the performance of the `EmptyParametersRule` in SwiftLint by ~35% compared to `509.0.0` (and by ~50% compared to `510.0.0`). Fixes swiftlang#2091 rdar://114330163
This gets us another ~3% performance improvement in SwiftLint listing time.
ahoppen
force-pushed
the
ahoppen/improve-visitor-performance
branch
from
ece8775 to
31575ca
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two core ideas here:
Syntax.Infofor every visited node. We need a heap-allocated object here becauseSyntaxcan access its parent. In most cases, however, the syntax node was not stored by the visitor and we would just destroy theSyntax.Infoafter finishing thevisitcall. Instead, check ifSyntax.Infois uniquely referenced, which means that the the node was not stored. In that case, don’t deallocate the memory but place it into a reuse pool. I have seen reductions inmalloccalls from ~50,000 to ~100 (500x) intestEmptyVisitorPerformance.I measured that this improves the performance of the
EmptyParametersRulein SwiftLint by ~35% compared to509.0.0(and by ~50% compared to510.0.0).Fixes #2091
rdar://114330163