Skip to content

[6.0] Allow return types on initializers #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahoppen merged 1 commit into from
Mar 20, 2024
Merged

[6.0] Allow return types on initializers #2553

ahoppen merged 1 commit into from
Mar 20, 2024

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 20, 2024

  • Explanation: SE-2305 allows returning Self and Self? from initializers so that the return type can be annotated with _borrow(a) etc. So we need to allow return clauses on initializers.
  • Scope: Parsing of initializers that have a return clause
  • Risk: I don’t see a risk in this change
  • Testing: Added a regression test
  • Issue: rdar://123905900
  • Reviewer: @bnbarham on Allow return types on initializers #2541

@ahoppen
Allow return types on initializers
595b97b 
SE-2305 allows returning `Self` and `Self?` from initializers so that the return type can be annotated with `_borrow(a)` etc.

So we need to allow return clauses on initializers.

rdar://123905900
@ahoppen ahoppen requested a review from bnbarham as a code owner March 20, 2024 14:06
@ahoppen
Copy link
Member Author

ahoppen commented Mar 20, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit e7071ef into swiftlang:main Mar 20, 2024
@ahoppen ahoppen deleted the ahoppen/6.0/return-type-on-initializer branch March 20, 2024 21:49
@ahoppen ahoppen restored the ahoppen/6.0/return-type-on-initializer branch March 22, 2024 12:49
@ahoppen ahoppen mentioned this pull request Mar 22, 2024
Merged
@ahoppen ahoppen deleted the ahoppen/6.0/return-type-on-initializer branch March 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahoppen @bnbarham