fixed-typed-throws-after-arrow-fixit #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppAppWorks
commented
Jul 16, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
7523e31
to
c8f261a
Compare
AppAppWorks
commented
Jul 16, 2024
AppAppWorks
commented
Jul 16, 2024
ahoppen
reviewed
Jul 16, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
c8f261a
to
2c2c810
Compare
AppAppWorks
commented
Jul 17, 2024
AppAppWorks
commented
Jul 17, 2024
ahoppen
reviewed
Jul 17, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
2c2c810
to
37be3b4
Compare
ahoppen
reviewed
Jul 18, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
3 times, most recently
from
07a7053
to
e6cf861
Compare
ahoppen
reviewed
Jul 23, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
e6cf861
to
a3f776e
Compare
ahoppen
reviewed
Jul 23, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
a3f776e
to
2976fc0
Compare
|
@ahoppen, could you review my latest commit? :) |
|
Did you try to address #2731 (comment)? |
I might have tried that but now I've forgotten it ;) |
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
2976fc0
to
1981651
Compare
|
#2731 (comment) addressed. |
ahoppen
approved these changes
Aug 7, 2024
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
1981651
to
c853e3b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
- `Parser.parseMisplacedEffectSpecifiers` will detect whether there is any misplaced typed throws. If yes, it will try to parse the thrown type and mark all tokens of the thrown type as missing. - `ParseDiagnosticsGenerator.handleMisplacedEffectSpecifiersAfterArrow` will recognize the entire throws clause as correct instead of the throws specifier only. - `ParseDiagnosticsGenerator.exchangeNodes` to replace `ParseDiagnosticsGenerator.exchangeTokens`, relaxing the input type from token to any syntax node. - refactored `TokenMissingMaker` in Declaration.swift, moved to Parser.swift, creating `Parser.withAllTokensMarkedMissing` for more generalized use.
auto-merge was automatically disabled
August 8, 2024 01:15
Head branch was pushed to by a user without write access
AppAppWorks
force-pushed
the
fix-typed-throws-after-arrow-fix-it
branch
from
c853e3b
to
c225440
Compare
|
Fixed, please test again. |
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2391