Skip to content

Allow custom derivate registration for _modify accessors #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Allow custom derivate registration for _modify accessors #2932

merged 3 commits into from
Jan 10, 2025

Conversation

asl
Copy link
Contributor

@asl asl commented Jan 9, 2025

This PR complements swiftlang/swift#78508

@asl asl requested review from ahoppen and bnbarham as code owners January 9, 2025 08:27
@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

@swift-ci please test

@asl asl mentioned this pull request Jan 9, 2025
Open
ahoppen
ahoppen reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add _modify as a choice here: https://github.com/swiftlang/swift-syntax/blob/6a8b21a85ccd5b9898a066b08a78835a0c375d66/CodeGeneration/Sources/SyntaxSupport/AttributeNodes.swift#L388C33-L388C34

@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

@swift-ci please test

ahoppen
ahoppen reviewed Jan 9, 2025
View reviewed changes
@asl asl force-pushed the modify-derivative-attr branch from 9617554 to 0e1b52a Compare January 9, 2025 19:54
@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

@ahoppen I'm not very familiar with SwiftSyntax internals and its testing infrastructure – any idea why the tests fail? Looks like some diff is produced, but no further information / message to track it down

@ahoppen
Copy link
Member

ahoppen commented Jan 9, 2025

You need to run code generation: https://github.com/swiftlang/swift-syntax/blob/main/CONTRIBUTING.md#generating-source-code

@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

You need to run code generation: https://github.com/swiftlang/swift-syntax/blob/main/CONTRIBUTING.md#generating-source-code

Ah, I see, thanks. It was the last changes that required this.

@asl
Copy link
Contributor Author

asl commented Jan 9, 2025

@swift-ci please test

@asl asl merged commit 37fa0c8 into main Jan 10, 2025
3 checks passed
@asl asl deleted the modify-derivative-attr branch January 10, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asl @ahoppen