Skip to content

Conversation

incertum
Copy link
Contributor

Signed-off-by: Melissa Kilby <mkilby@apple.com>
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @incertum 🙏🏽 Two quick questions:

  • Out of curiosity, do you know what the default permissions are if they are not specified? Does this PR just
  • The automerge workflow requires contents: write permission in the create_merge_pr job. Do you know / did you check if it’s possible that a job has more permissions than the surrounding workflow?

@incertum
Copy link
Contributor Author

Thanks a lot for the PR, @incertum 🙏🏽 Two quick questions:

  • Out of curiosity, do you know what the default permissions are if they are not specified?

The default GITHUB_TOKEN permissions are defined at the repository level. This PR modifies the workflow-level overrides to conform to OpenSSF best practices -> defense in depth.

  • The automerge workflow requires contents: write permission in the create_merge_pr job. Do you know / did you check if it’s possible that a job has more permissions than the surrounding workflow?

I replied to a similar question here: swiftlang/swift-build#858 (comment) Hope it answers the question?

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, @incertum 🙏🏽

@ahoppen
Copy link
Member

ahoppen commented Oct 14, 2025

@swift-ci Please test

@ahoppen ahoppen merged commit cc7888f into swiftlang:main Oct 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants