Proper indentation and line breaks for Switch/Case and Closure #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jun 14, 2022
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
IIUC you edited the files in the gyb_generated manually. The next time we re-generate those, the changes will be overwritten. You would need to find a way to make these changes in the corresponding .swift.gyb files and then trigger generation of these files using ./build-script.py --degyb-only --toolchain /does/not/matter.
Contributor
Author
|
I didn't change those files manually. Please check related swiftlang/swift#59430 for changes in the sources used to generate files in the |
ahoppen
approved these changes
Jun 14, 2022
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Sorry, I didn’t see that PR. Could you mention any matching apple/swift PRs in the PR’s description next time so I don’t miss it again?
Member
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Remove `prefixPeriod`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.