Fix a failing time-sensitive test. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the tests for our `.timeLimit()` trait uses `Clock.measure {}` to determine how long it takes to execute, but that's unsafe because it will include time spent waiting for the Swift runtime and the OS to schedule the child task in which the test runs. That time may be significant when tests are running in parallel.
This PR modifies that test to explicitly measure the start of the test when the test function is entered and the end of the test when the local test run completes. This avoids accidentally measuring any initial wait time.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
CI shows the test passing now. Remaining failure on Linux is fixed by swiftlang/swift-package-manager#7273. |
stmontgomery
approved these changes
Jan 18, 2024
grynspan
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tests for our
.timeLimit()trait usesClock.measure {}to determine how long it takes to execute, but that's unsafe because it will include time spent waiting for the Swift runtime and the OS to schedule the child task in which the test runs. That time may be significant when tests are running in parallel.This PR modifies that test to explicitly measure the start of the test when the test function is entered and the end of the test when the local test run completes. This avoids accidentally measuring any initial wait time.
Checklist: