Add skipped test tracking to JUnit output. #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds skipped test reporting to our JUnit XML output. For example, given this test: ```swift @test(.disabled("Because I said so")) func f() {} ``` The XML output would be, approximately: ```xml <?xml version="1.0" encoding="UTF-8"?> <testsuites> <testsuite name="TestResults" errors="0" tests="1" failures="0" skipped="1" time="12345.0"> <testcase classname="MyTests" name="f()" time="12344.0"> <skipped>Because I said so</skipped> </testcase> </testsuite> </testsuites> ``` See also swiftlang/swift-package-manager#7383 which asks for this for XCTest.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
Ah nice, thanks! |
briancroom
approved these changes
Jul 18, 2024
| @@ -183,14 +209,19 @@ extension Event.JUnitXMLRecorder { | |||
| /// | |||
| /// - Returns: `character`, or a string containing its escaped form. | |||
| private static func _escapeForXML(_ character: Character) -> String { | |||
| if character == #"""# { | |||
| switch character { | |||
There was a problem hiding this comment.
> isn't required to be escaped in XML attributes, but & definitely is. Could you add that?
There was a problem hiding this comment.
Gonna leave > out of pedantry, but yeah I'll add &.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds skipped test reporting to our JUnit XML output. For example, given this test:
The XML output would be, approximately:
See also swiftlang/swift-package-manager#7383 which asks for this for XCTest.
Checklist: