Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Update install to ensure the build directory is not added to the rpath #832

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

grynspan
Copy link
Contributor

Per @bnbarham:

This seems to be fine with the existing CMake, but in 3.29 (possibly earlier) the rpath of libTesting still has the build directory. Make sure to remove any existing build rpath.

Update install to ensure the build directory is not added to the rpath
@grynspan grynspan changed the base branch from main to release/6.0 November 19, 2024 19:04
@grynspan grynspan added bug Something isn't working build Affects the project's build configuration or process labels Nov 19, 2024
@grynspan grynspan added this to the Swift 6.0.3 milestone Nov 19, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to cherry-pick this. LGTM.

@grynspan
Copy link
Contributor Author

The Windows failure is a known issue in SwiftPM on main. @dschaefer2 is looking at it.

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@dschaefer2
Copy link
Member

You need to make your Testing library product with type .dynamic if you want it to export symbols with the 6.1-dev Windows toolchain.

@grynspan
Copy link
Contributor Author

It is beyond the scope of this PR to change the package manifest settings.

We can just ignore the Windows failure for now, I suppose, since we know what's causing it.

@shahmishal shahmishal merged commit 18c42c1 into release/6.0 Nov 22, 2024
3 checks passed
@shahmishal shahmishal deleted the jgrynspan/fix-rpaths-6.0 branch November 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Affects the project's build configuration or process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants