Revert "Introduce a severity level for issues, and a 'warning' severity (#931)" #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty (swiftlang#931)" This reverts commit 6a49142.
stmontgomery
added
bug
stmontgomery
requested review from
grynspan,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
Caused by #931 |
|
@swift-ci please test |
2 tasks
stmontgomery
added a commit
to stmontgomery/swift-testing
that referenced
this pull request
Feb 12, 2025
…evert swiftlang#931) Revert "Merge pull request swiftlang#950 from stmontgomery/revert-issue-severity" (swiftlang#950) This reverts commit 9998633, reversing changes made to 55d0023.
2 tasks
stmontgomery
added a commit
that referenced
this pull request
Feb 12, 2025
…evert #931) (#952) This un-reverts #950, effectively reintroducing the changes recently landed in #931. The revert was needed because it revealed a latent bug in the Swift compiler, tracked by swiftlang/swift#79304. I reproduced that failure and included a workaround in the second commit on this PR. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
stmontgomery
added a commit
that referenced
this pull request
Feb 12, 2025
…#951) This modifies `Package.swift` to enable Library Evolution for builds of the package. ### Motivation: I recently landed a change (#931) which passed our project-level CI but later failed in Swift CI. The difference ended up being due to the latter building with Library Evolution (LE) enabled, whereas our project-level CI builds via SwiftPM and does not enable LE. The change was reverted (#950) but this revealed a gap in our testing strategy. We should always build these targets with LE enabled. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated. Fixes rdar://144655439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#931 exposed a problem in newer compilers, tracked by swiftlang/swift#79304. I intend to investigate and modify my code after finding a workaround, but revert temporarily for now.
This reverts commit 6a49142.