Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require sendable userInfo values in JSON.withEncoding(of:userInfo:_:) #959

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Require sendable userInfo values in JSON.withEncoding(of:userInfo:_:) #959

merged 1 commit into from
Feb 13, 2025

Conversation

bnbarham
Copy link
Contributor

Re-applies #955

@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham mentioned this pull request Feb 13, 2025
Draft
@grynspan grynspan added bug Something isn't working build Affects the project's build configuration or process labels Feb 13, 2025
@grynspan grynspan added this to the Swift 6.x milestone Feb 13, 2025
@grynspan
Copy link
Contributor

We'll let you merge this when you're ready.

@bnbarham
Copy link
Contributor Author

Toolchain passed - https://ci.swift.org/job/swift-PR-toolchain-Linux/1263/. Sorry for reverting!

@bnbarham bnbarham merged commit 0e7ce39 into main Feb 13, 2025
3 checks passed
@bnbarham bnbarham deleted the revert-957-revert-955-JSONEncoder-sendable-userInfo branch February 13, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@grynspan grynspan grynspan approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@bnbarham bnbarham

Labels
bug Something isn't working build Affects the project's build configuration or process
Projects
None yet
Milestone
Swift 6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @grynspan @stmontgomery