[BSP] Make MessageRegistry.bspProtocol a static stored property #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight and
owenv
as code owners
owenv
approved these changes
Nov 21, 2025
ahoppen
approved these changes
Nov 22, 2025
|
|
||
| @available(*, deprecated, message: "use MessageRegistry.bspProtocol instead") | ||
| public let bspRegistry = MessageRegistry(requests: requestTypes, notifications: notificationTypes) | ||
| public let bspRegistry = MessageRegistry.bspProtocol |
Member
There was a problem hiding this comment.
Should this be a computed property so we don't store the BSP registry twice if anyone is using the deprecated accessory?
This should be an immutable value and `MessageRegistry.init()` is not a trivial constructor. No reason to keep it a computed property. Also, Move `MessageRegistry.lspProtocol` to LanguageServerProtocol/Messages.swift to align with the BSP couterpart.
rintaro
force-pushed
the
bspregistry-static
branch
from
2fd8438 to
2422d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be an immutable value and
MessageRegistry.init()is not a trivial constructor. No reason to keep it a computed property.Also, Move
MessageRegistry.lspProtocolto LanguageServerProtocol/Messages.swift to align with the BSP couterpart.