Expose less SPI from ToolsProtocolsSwiftExtensions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
approved these changes
Oct 14, 2025
| #else | ||
| // TODO: @preconcurrency needed because stderr is not sendable on Linux https://github.com/swiftlang/swift/issues/75601 | ||
| @preconcurrency package import Foundation | ||
| @preconcurrency public import Foundation |
There was a problem hiding this comment.
Did you intentionally increase the import level here?
There was a problem hiding this comment.
yeah, this is needed to fix a break in the Linux build
There was a problem hiding this comment.
Out of curiosity: What was the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid exposing trivial utilities as SPI where we don't need to