Use URL.resourceValues() for symlink detection
#428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
force-pushed
the
use-resourceValues-for-symlink-detection
branch
2 times, most recently
from
0eff15a to
3091008
Compare
|
@swift-ci please test |
MaxDesiatov
reviewed
Aug 14, 2023
tomerd
reviewed
Aug 14, 2023
This should provide a significant performance improvement on macOS. See [this](swiftlang#400 (comment)]) for more discussion on non-macOS platforms. Co-authored-by: Pyry Jahkola <pyry.jahkola@iki.fi>
neonichu
force-pushed
the
use-resourceValues-for-symlink-detection
branch
from
3091008 to
06d5f76
Compare
|
@swift-ci please test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
|
OK, no Windows, I guess ¯\_(ツ)_/¯ |
|
probably worth doing cross-repo run via SwiftPM |
We're already testing SwiftPM through the regular smoke tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide a significant performance improvement on macOS. See this for more discussion on non-macOS platforms.