Skip to content

Windows toolchain - swiftToCxx directory missing #63446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #65808
litewrap opened this issue Feb 6, 2023 · 5 comments · Fixed by swiftlang/swift-installer-scripts#191
Closed
Tracked by #65808

Windows toolchain - swiftToCxx directory missing #63446

litewrap opened this issue Feb 6, 2023 · 5 comments · Fixed by swiftlang/swift-installer-scripts#191
Assignees
@compnerd
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ platform support swift 5.9 toolchain Windows Platform: Windows

Comments

@litewrap
Copy link

litewrap commented Feb 6, 2023 •
edited
Loading

Description
swiftToCxx directory is missing in the Swift Windows toolchain

Steps to reproduce

Directory: C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\swift


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----          2/3/2023   9:09 AM                migrator
d-----          2/3/2023   9:09 AM                pm

Expected behavior

\usr\lib\swift must include the swiftToCxx directory and the content include the following header files:
_SwiftCxxInteroperability.h
_SwiftStdlibCxxOverlay.h
@litewrap litewrap added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Feb 6, 2023
@AnthonyLatsis AnthonyLatsis added toolchain Windows Platform: Windows platform support c++ interop Feature: Interoperability with C++ and removed triage needed This issue needs more specific labels labels Feb 6, 2023
@AnthonyLatsis
Copy link
Collaborator

Please include the Swift version.

@hyp
Copy link
Contributor

hyp commented Feb 10, 2023

@compnerd do you by any chance know why /usr/lib/swift doesn't include a lot of things on Windows?

@compnerd
Copy link
Member

@hyp the answer is two folds:

  1. Separation between toolchain and SDK.

The content in the toolchain should be target agnostic.

  1. People add things without testing on windows.

There is an explicit list of things that are packaged for distribution. That lives in the installer sources at sdk-amd64 and runtime-amd64 for X64, with variants for X86, ARM64, and ARMv7.

@litewrap
Copy link
Author

litewrap commented Feb 11, 2023 •
edited
Loading

@AnthonyLatsis

All Swift versions, including the 5.8 and latest snapshot

@hyp hyp mentioned this issue May 9, 2023
Closed
22 tasks
@hyp
Copy link
Contributor

hyp commented May 16, 2023

@compnerd let me know if you'll be able to look at this. I will assign it to you for now, but feel free to send it back to me if you think you won't have bandwidth.

compnerd added a commit to compnerd/swift-installer-scripts that referenced this issue May 16, 2023
@compnerd
WiX: add swiftToCxx content to the toolchain distribution
af8bfe8 
Include the `swiftToCxx` content as compiler resources for the Swift
compiler for the distribution.  This is part oft the C++ interop work.

Fixes: swiftlang/swift#63446
@compnerd compnerd mentioned this issue May 16, 2023
Merged
compnerd added a commit to compnerd/swift-installer-scripts that referenced this issue May 16, 2023
@compnerd
WiX: add swiftToCxx content to the toolchain distribution
7e7c946 
Include the `swiftToCxx` content as compiler resources for the Swift
compiler for the distribution.  This is part oft the C++ interop work.

Fixes: swiftlang/swift#63446
compnerd added a commit to swiftlang/swift-installer-scripts that referenced this issue May 17, 2023
@compnerd
WiX: add swiftToCxx content to the toolchain distribution
58e3357 
Include the `swiftToCxx` content as compiler resources for the Swift
compiler for the distribution.  This is part oft the C++ interop work.

Fixes: swiftlang/swift#63446
compnerd added a commit to compnerd/swift-installer-scripts that referenced this issue May 17, 2023
@compnerd
WiX: add swiftToCxx content to the toolchain distribution
12f30ea 
Include the `swiftToCxx` content as compiler resources for the Swift
compiler for the distribution.  This is part oft the C++ interop work.

Fixes: swiftlang/swift#63446
@compnerd compnerd mentioned this issue May 17, 2023
Merged
compnerd added a commit to swiftlang/swift-installer-scripts that referenced this issue May 18, 2023
@compnerd
WiX: add swiftToCxx content to the toolchain distribution
515b345 
Include the `swiftToCxx` content as compiler resources for the Swift
compiler for the distribution.  This is part oft the C++ interop work.

Fixes: swiftlang/swift#63446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ platform support swift 5.9 toolchain Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WiX: add swiftToCxx content to the toolchain distribution compnerd/swift-installer-scripts
4 participants
@compnerd @hyp @AnthonyLatsis @litewrap