Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cxx-interop] std::optional should provide nullable access to the wrapped object #65918

Closed
Tracked by #65808
egorzhdan opened this issue May 15, 2023 · 0 comments · Fixed by #65919
Closed
Tracked by #65808

[cxx-interop] std::optional should provide nullable access to the wrapped object #65918

egorzhdan opened this issue May 15, 2023 · 0 comments · Fixed by #65919
Assignees
@egorzhdan
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++

Comments

@egorzhdan
Copy link
Contributor

std::optional provides a Swift property var value via an extension to CxxOptional.
This property is not null-safe. It should have a nullable type instead.
@egorzhdan egorzhdan added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ labels May 15, 2023
@egorzhdan egorzhdan self-assigned this May 15, 2023
egorzhdan added a commit that referenced this issue May 15, 2023
@egorzhdan
[cxx-interop] Make std.optional.value nullable
7d78255 
rdar://109356566 / resolves #65918
@egorzhdan egorzhdan mentioned this issue May 15, 2023
Merged
@hyp hyp mentioned this issue May 15, 2023
Closed
22 tasks
egorzhdan added a commit that referenced this issue May 16, 2023
@egorzhdan
[cxx-interop] Make std.optional.value nullable
6c9d141 
rdar://109356566 / resolves #65918
(cherry picked from commit 7d78255)
@egorzhdan egorzhdan mentioned this issue May 16, 2023
Merged
meg-gupta pushed a commit to meg-gupta/swift that referenced this issue May 22, 2023
@egorzhdan @meg-gupta
[cxx-interop] Make std.optional.value nullable
7875ab9 
rdar://109356566 / resolves swiftlang#65918
NuriAmari pushed a commit to NuriAmari/swift that referenced this issue May 28, 2023
@egorzhdan @NuriAmari
[cxx-interop] Make std.optional.value nullable
4e29758 
rdar://109356566 / resolves swiftlang#65918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egorzhdan egorzhdan

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cxx-interop] Make std.optional.value nullable swiftlang/swift
1 participant
@egorzhdan